Closed troughc closed 3 days ago
@dev-aravind This requires backend changes. Please look into this. Thanks.
@AbhishekPAnil This issue should be handled by the frontend as there is no way of knowing whether if an event was updated by the CMS or the Aggregator. (We don't need to delink the issue if the update was done by the aggregator.)
Tested in signe laval
Expected behavior: User opens a published and linked event series and modifies the dates in some way. User saves
The event series is delinked from Artsdata.
I modified this event but it is still linked to Artsdata: https://pr-1243.dla06mbe0wyl7.amplifyapp.com/dashboard/63457978637093005071a053/events/665832c48c76ef0064569ab5
And this one: Tente à lire au parc Saint-Martin https://pr-1243.dla06mbe0wyl7.amplifyapp.com/dashboard/63457978637093005071a053/events/6669113c92cafd0064973fe9
@troughc Did you open the pop up for editing the event dates or just added the weekdays ?
@troughc Did your testing work when changing an event series date to daily,date range ?Was the artsdata link removed during these changes?
@troughc Did you open the pop up for editing the event dates or just added the weekdays ?
I did NOT open the popup (custom dialog). I just edited the days and times in the main CMS window.
NOTE: I just did a test where i changed it in the custom dialog and the artsdata link goes away in that case: https://pr-1243.dla06mbe0wyl7.amplifyapp.com/dashboard/63457978637093005071a053/events/6669114c92cafd00649741a0
BUT it does NOT go away if I do not open up the custom dialog.
@troughc Did your testing work when changing an event series date to daily,date range ?Was the artsdata link removed during these changes?
@AbhishekPAnil I just tested this one - changed from weekly to date range: https://pr-1243.dla06mbe0wyl7.amplifyapp.com/dashboard/63457978637093005071a053/events/6669113c92cafd0064973fe9
It did not remove the Artsdata link - the Artsdata link is still there.
@AbhishekPAnil I am having trouble accessing https://pr-1243.dla06mbe0wyl7.amplifyapp.com (my password is wrong and I cannot reset it because my email is not recognized) and I think this may have already been merged into the main branch. I think we should close this as I am not sure what I am testing. I have a series of Use cases to test (https://docs.google.com/document/d/1RyxNVXH1KieJ-ey-cGAp60pb8J7foiCu_Yv7o1tsVN0/edit#heading=h.cwuaj9tkpntl) and I will continue testing using data in the Crow's Theatre Calendar moving forward and can open a new issue if needed.
@AbhishekPAnil My first test did not pass (unlucky).
I edited this event Laurent Paquin https://pr-1243.dla06mbe0wyl7.amplifyapp.com/dashboard/6308ef4a7f771f00431d939a/events/64af64803c19fa0064e77639
After I changed the sub-events to make 6 occurrences instead of 3, I saved the event. However the event series was still linked to Artsdata. I expected it to no longer be linked.
There is a bigger problem. Whenever I click "edit" on an event with multiple "occurences" the dates disappear.
Read only screen:
Unexpectedly the dates have disappeared and the frequency is daily.
@AbhishekPAnil I have having trouble testing. When I click to edit an event, and then click publish without making any changes, the event disappears. Can you reproduce this as well?
@AbhishekPAnil I have having trouble testing. When I click to edit an event, and then click publish without making any changes, the event disappears. Can you reproduce this as well?
Yes , I was able to reproduce the same. The reason I didn't notice this initially was because I used the event's id to come back to edit page every time.
@AbhishekPAnil It was a backend-related issue. The issue has been fixed and deployed. Can you please review it? If it looks good, then please assign it for review.
@AbhishekPAnil This Toutculture event "Marc Dupré" has 2 occurences, but when I click "edit" button the multiple date range is not shown (see screen grab). Another example is the event "Christian Marc Gendron" also in Toutculture. I didn't edit either event. Is this something that needs to be fixed as part of this issue?
@AbhishekPAnil Looking good. I'm passing this so we can deploy into production. It will help remove some incorrect linking between Artsdata and Footlight. There is still work to do to synchronize links between Artsdata and Footlight, but it I am thinking it will probably be the responsibility of an outside process. We currently have a script that adds missing Artsdata ID to Footlight CMS, and my next thought on addressing more work in this area is to re-design that script running outside of Footlight CMS to not only add missing Artsdata IDs but to also sync Artsdata IDs by checking event dates and location. So for now there is nothing more to do in your REACT code.
In an event with multiple dates (event series), when the dates are modified in the CMS by a user in any way, the event series in the CMS should be delinked from Artsdata (it is no longer valid) after saving. Examples of date changes:
Expected behavior: User opens a published and linked event series and modifies the dates in some way. User saves.
cc @saumier
Test event : Example event: https://staging.api.footlight.io/events/666144a5beddbb0064698f83
Test Cases :
Remember to bypass the privacy window by going to the swagger link : https://15.222.238.246/api/