search

cursorless-dev / cursorless

Don't let the cursor slow you down
https://www.cursorless.org/
MIT License
1.15k stars 81 forks source link

"item" not properly visualized in visualizer #2663

Open maciejklimek opened 2 months ago

maciejklimek commented 2 months ago

it looks like the "item" is not properly visualized. Here is the screenshot. image

AndreasArvidsson commented 2 months ago

The text based(splitting on comma) implementation of collection item is still in legacy. There's nothing wrong with the visualizer per se. That is why you can't say "take next item" in a comma separated list.

maciejklimek commented 2 months ago

sorry I don't understand. There are two dictionaries in the code. Shouldn't the visualizer show their items?

AndreasArvidsson commented 2 months ago

sorry I don't understand. There are two dictionaries in the code. Shouldn't the visualizer show their items?

Yes eventually, but not with the current implementation. Comma separated lists are implemented in a language agnostic, text only way. That is still in the legacy implementation and is therefore not supported by the new grammar or the scope visualizer. Once we update that we will get comma separated lists for all languages in the scope visualizer.