search

custom-components / zaptec

zaptec charger custom component for home assistant
MIT License
67 stars 20 forks source link

More about load balancing, better formatting. #93

Closed svenakela closed 8 months ago

svenakela commented 10 months ago

The contribution about load balancing was messing up the readme, I moved some text and added more info.

sveinse commented 10 months ago

I have one concern: I think its important that the features or implementations of the load balancing blueprint is not tied too tightly with this project. If we do, this will result in this repo having to update whenever new features were changed in the blueprint repo. So I think the readme should give very general information that the load balancing blueprint exists and then refer to the blueprint repos readme.

svenakela commented 10 months ago

I have one concern: I think its important that the features or implementations of the load balancing blueprint is not tied too tightly with this project. If we do, this will result in this repo having to update whenever new features were changed in the blueprint repo. So I think the readme should give very general information that the load balancing blueprint exists and then refer to the blueprint repos readme.

I don't mind, feel free to remove as much as you like. Maybe even move to the bottom of the readme as "Usage Examples" or similar?

svenakela commented 9 months ago

@sveinse had some spare time to adjust the readme. I've shortened the text and moved it to the bottom of the file.

svenakela commented 8 months ago

@sveinse is this PR stale? The updates are at least much better than the previously approved adds.

sveinse commented 8 months ago

@svenakela the PR isn't, but I am 🥲 I'll have to take a look at this as soon as I have the opportunity.