cutiepi-io / cutiepi-shell

A mobile shell for Raspberry Pi OS
https://cutiepi.io
GNU General Public License v3.0
232 stars 25 forks source link

Changing system rotation breaks shell rotation #18

Open tamara-schmitz opened 2 years ago

tamara-schmitz commented 2 years ago

The Raspberry Pi OS image ships a display configuration utility which can be used to edit the X.org config.

It allows you to set a rotation so that for example the Pi desktop is oriented as you would expect.

When you set the display orientation to anything other than none, like "left" for example, the Cutiepi-shell cannot deal with that and will draw outside the screenspace and with the wrong orientation.

Please let the Pi-shell take into account the X11 rotation setting, so that it is possible to use the desktop in landscape mode without breaking Cutiepi-shell.

penk commented 2 years ago

@tamara-schmitz thank you so much for reporting this!

In the 2022-01-23 image we did enable Xorg rotation with iio-sensor-proxy, so it does support desktop rotation.

However the Mutter transformation isn't animated, so we did a complicated: sensor rotate -> lock orientation -> (go into Shell) -> use Qt's rotation animation -> (go back to desktop) -> unlock orientation

It works but it's not ideal, and we do need to take for example xrandr or xorg.conf into account.

tamara-schmitz commented 2 years ago

So if I understand this correctly as of now, when I minimise the Pi-shell there is no desktop rotation. But when I go into cutiepi-shell settings and switch to Desktop Mode there, I get desktop rotation?

penk commented 2 years ago

@tamara-schmitz

hope that helps?