Feature #1034 Validate All Cards

[Haviles04]

Issue number

Relevant issue number

• Resolves #1034

Please check the following

• [x] Do the tests still pass? (see Run the Tests)
• [x] Is the code formatted properly? (see Linting (Formatting))
• For New Features:
  • [x] Have tests been added to cover any new features or fixes?
  • [ ] Has the documentation been updated accordingly?

Please describe additional details for testing this change

-Added Validation of all cards in gamestate -Added unit test -Updated load-fixture and load-fixture-gamestate to fill the deck or the scrap

[Haviles04]

Todo: Add the rest of the cards to the unit test fixtures

[Haviles04]

The other option to this code would look something like this

@itsalaidbacklife , @seriouslysean , Thoughts on which is better?

const keys = ['p0', 'p1', 'deck', 'scrap', 'twos', 'oneOff'];

    const validateCard = (card, allowAttachments) => {
      if (card.attachments.length && !allowAttachments) {
        throw new Error('Only Points and Face Cards can have attachments');
      }

      if (cardIds.has(card.id)) {
        throw new Error('Duplicate Card');
      }

      if (!deckIds.has(card.id)) {
        throw new Error('Invalid Card');
      }

      cardIds.add(card.id);
    };

    for (const key of keys) {
      let allowAttachments = false;
      if (!gameState[key]) {
        return;
      }

      if (key === 'oneOff') {
        return validateCard(gameState[key], allowAttachments);
      }

      if (['p0', 'p1'].includes(key)) {
        ['hand', 'points', 'faceCards'].forEach((playerKey) => {
          if (['points', 'faceCards'].includes(playerKey)) {
            allowAttachments = true;
          } else {
            allowAttachments = false;
          }
          return gameState[key][playerKey].forEach((card) => {
            validateCard(card, allowAttachments);
            if (allowAttachments) {
              card.attachments.forEach((card) => {
                validateCard(card, false);
              });
            }
          });
        });
      }
      gameState[key].forEach((card) => {
        validateCard(card, allowAttachments);
      });
    }

[itsalaidbacklife]

Let's add unit tests for the new validate function to show that it errors on a few known cases:

• duplicate card found
• unrecognized card found
• card missing
• attachments on car in scrap