search

cvut / qtrvsim

RISC-V CPU simulator for education purposes
GNU General Public License v3.0
466 stars 56 forks source link

GUI: use toggle in main window triggered action #106

Open trdthg opened 6 months ago

trdthg commented 6 months ago

trying to fix #58, There is only one button now.

Any suggestions? Should I continue?

jdupak commented 6 months ago

Hi @trdthg, welcome, and thanks for your contribution! I will review it soon.

However, one issue is, that we never concluded on whether this is a good idea for user experience. That is why it was not marked with any issue labels. Unfortunately, we had this discussion in person, so it was not visible with the issue. Sorry for that.

@ppisa I am thinking that we might publish this in an extra WASM URL and ask students to comment on it on Discord. What do you think?

ppisa commented 6 months ago

I am not sure what is the best direction there. I have nothing against inclusion of support for toggle as addition to show in the code in general. But the series should be cleaned. As for shortcuts, I am not sure. I think that it is better to keep option, which ensures that pressing the combination ensures activation/show of the dock and be sure that it is visible. That is separate show only shortcut is useful. Close is easy by mouse, because you see what is there and you want to remove from the screen. If there is enough unallocated shortcuts then separate combination for making dock visible and another (for example with Ctrl or Shift) to close dock could be useful. But toggling does not lead to steady state and you need to analyze the first if dock is missing or moved somewhere where it is not well visible and then decode if to press it to make dock visible or if mouse drag is required.

So I am not sure if this change is useful.