Open trdthg opened 4 months ago
I will address the other questions shortly.
What about programloader tests, should we now simply hand write tests to cover as many instructions and section types as possible, or look for ways to reuse the sail-riscv test set? (The latter seems pretty complicated.)
I don't think we need to dig into the instructions here. We need to test the loading functionality. I think it would be nice to come up with one executable with various sections and then "randomly" check the contents of the memory. As for sail-riscv, as far as I understand, they are just binaries of the official risc-v test, which we are running already (see the CI).
Do you have any suggestions on the method I'm using here, or provide more test topics?
I like your approach. Since you have the pairs already generated, I would love to add also the other direction (code_from_string
).
After that, there are many commented-out MIPS tests in the core.test.cpp
. Converting them to RISC-V would be great.
We will be able to close #7 once all QSKIP calls are gone.
Good work so far. Some notes.
Completely refactored
Now instruction.test.gendata.cpp iterates through all the instructions on instruction_map, tries to generate 100 (code and string_data)pair for each, then checks to_str
and code_from_string
and fails if they don't match.
The current generation logic relies on arg_desc's min and max.
This is an executable file, the output looks like this:
...
inst: [jalr]
- [ 0] code: [ fb268267] str: [ jalr x4, -78(x13)]
- [ 1] code: [ 7dce8a67] str: [ jalr x20, 2012(x29)]
- [ 2] code: [ cfc78ee7] str: [ jalr x29, -772(x15)]
...
inst: [j]
- [ 0] code: [ e32f006f] str: [ j -0xf9ce]
...
...
Since it can't generate a fixed test case every time you run this script, the file name shouldn't be gendata anymore. I tried to move the code from main to instruction.test.cpp, but fails.
Because there are too many structures used here that instruction.cpp doesn't expose (e.g. ArgumentDesc, C_inst_map, fill_argdesbycode ...), So I include instruction.cpp
directly.
@jdupak could you give me some advise?
Related to #7
This demo currently adds some test cases for instruction_to_str(), and also includes a demo function to generate test cases
@jdupak