cweijin / pe

0 stars 0 forks source link

Error message does not specify NRIC format #5

Open cweijin opened 1 week ago

cweijin commented 1 week ago

For example, T0123456B exists in the system, then t0123456b is the same and should refer to this patient. The only restriction stated in help window is that NRIC must be a valid NRIC currently in the system, which means t0123456b should also considered 'valid'. However, it is not accepted. Users might not be able to figure out what's wrong and brings major inconvenience.

There is no information about this case sensitivity in error message / help message / UG under delete

image.png

image.png

nus-pe-script commented 5 days ago

Team's Response

As stated in our planned enhancements (point 3) in UG and DG, we will work on parsing NRIC case-insensitively. Furthermore, it is also specified in the UG that all NRIC used for all commands requiring NRIC should follow a specific format of having uppercase alphabets.

image.png

Since, this was mentioned in our UG and DG as planned enhancements and following the PE Bug triaging guidelines, we reject this bug.

Screenshot 2024-11-18 at 3.16.25 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: To clarify, my bug report highlights the lack of specificity in the error message, which fails to guide users adequately when their command is rejected due to case sensitivity.

Issue

When users input an NRIC in lowercase, the app displays an error message stating:

Invalid command format!
delete usage: delete [NRIC]
Input "help delete" for detailed description and usage of this command

However, upon checking with help delete, the user is only provided with the generic statement:

NRIC provided must be a valid NRIC currently in the system.

At no point is the user informed about the case sensitivity requirement for NRIC. Consequently, users may remain unaware of the root cause of the issue, leading to confusion and potentially lengthy processes to figure out why their command is being rejected.

Why is this a bug

Impact

The vague error message creates a significant usability issue:

Suggested Severity

image.png