search

cwi-dis / VR2Gather

Unity application framework for immersive social VR
MIT License
2 stars 6 forks source link

Unify interfaces for the various Pipelines #156

Closed jackjansen closed 3 months ago

jackjansen commented 5 months ago

All the pipelines (PointCloud, WebCam) have different interfaces, and the Voice ones even have different names. (Sender and Receiver).

We should unify this, and probably also make them "normal" Unity objects.

At the moment they do most of their initialisation in Init(), but really they should only remember the parameters here (and, incidentally, all the Init() should get the same signature).

Then they should do further setup in Awake() and Start(), just like normal components.

jackjansen commented 5 months ago

The signatures of the voice pipeline self/other Init() calls have been brought isomewhat n line with those of the other pipelines.

Due to #157 we cannot unify these further at the moment.

Will merge the branch but keep the issue open for future fixing.

jackjansen commented 3 months ago

Fixed in d26d100 except for WebRTC but that has its own issue.