cyberark / conjur-api-python

Python client for the CyberArk Conjur API
Apache License 2.0
8 stars 3 forks source link

Add role memberships endpoint #33

Closed gl-johnson closed 2 years ago

gl-johnson commented 2 years ago

Desired Outcome

Support the Role Membership endpoint. Default behavior should use the recursive membership method (?all), but also support direct membership only queries (?memberships).

Implemented Changes

Added the following URL template and relevant API methods to return a JSON list of role memberships: ROLES_MEMBERSHIPS = "{url}/roles/{account}/{kind}/{identifier}?{membership}"

Connected Issue/Story

CyberArk internal issue link: ONYX-24035

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

Test coverage

Documentation

Behavior

Security

szh commented 2 years ago

Looks good. I just want to wait until you have a draft PR in the CLI so I can see the integration tests and verify the output is the same as in the Ruby API.

gl-johnson commented 2 years ago

CLI PR with integration tests