cyberark / conjur-cli-go

CyberArk Conjur command line interface (Go)
Apache License 2.0
4 stars 2 forks source link

Upgrade API key rotation to support fully- and partially-qualified IDs #111

Closed john-odonnell closed 1 year ago

john-odonnell commented 1 year ago

Desired Outcome

Allow conjur [user|host] rotate-api-key to accept fully- and partially-qualified IDs.

Implemented Changes

Use the latest version of conjur-api-go, which allows Rotate[User|Host]APIKey() functions to accept both fully- and partially-qualified role IDs.

Add integration test cases to ensure the CLI can rotate a [user|host]'s role given an ID of varying degrees of qualification.

Connected Issue/Story

N/A

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

Test coverage

Documentation

Behavior

Security

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 0df6eddd and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.8% (0.0% change).

View more on Code Climate.