cyberark / conjur-cli-go

CyberArk Conjur command line interface (Go)
Apache License 2.0
4 stars 2 forks source link

Fix: Handle trailing slash on Appliance URL #142

Closed doodlesbykumbi closed 1 year ago

doodlesbykumbi commented 1 year ago

Desired Outcome

Depends on https://github.com/cyberark/conjur-api-go/pull/179, which updates conjur-api-go to seamlessly handle traling slashes on the Appliance URL

This PR

  1. Adds an integration test for init and login using an Appliance URL with a trailing slash
  2. Updates go.mod files to use the new version of conjur-api-go

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In particular, consider:

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

Test coverage

Documentation

Behavior

Security

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 8f0bc2b9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.3% (0.0% change).

View more on Code Climate.

UberKitten commented 1 year ago

Finally! This has been so annoying, especially since there wasn't an obvious error.