search

cyberark / cyberark-aws-auto-onboarding

Solutions for automatically detecting, managing and securing privileged accounts in AWS EC2
Apache License 2.0
40 stars 32 forks source link

Removed boto3 dependency - Fix #7 #8

Closed infamousjoeg closed 4 years ago

infamousjoeg commented 6 years ago

Removed boto3 dependency since it is not needed in an AWS Lambda Function.

NOTE: I did not recompile the dist directory files. This should still be done.

infamousjoeg commented 5 years ago

@nimrody15 @zivshits can I get a couple reviews on this PR?

zivshits commented 5 years ago

@nimrody15 @zivshits can I get a couple reviews on this PR?

Hey Joe, Currently we don't have an automatic testing environment. Can you please describe which tests did you perform?

infamousjoeg commented 5 years ago

@nimrody15 @zivshits can I get a couple reviews on this PR?

Hey Joe, Currently we don't have an automatic testing environment. Can you please describe which tests did you perform?

When I deployed this in October 2018, I used my version that didn't include boto3. Boto3 is provided by AWS' Lambda service by default.

yogevh commented 4 years ago

boto 3 is needed now for multi-region, multi account support