cyberark / secretless-broker

Secure your apps by making them Secretless
Apache License 2.0
234 stars 42 forks source link

Fix(aws-connector): Limit signing to signed headers from original request #1432

Closed doodlesbykumbi closed 2 years ago

doodlesbykumbi commented 2 years ago

What does this PR do?

Prior to this change the AWS connector was signing requests using all the headers present on the original request. This was resulting signature mismatches and failed auth, particularly visible when creating a new s3 bucket. With this change the aws connector will sign only the headers on the original request, it achieves this by temporarily hiding the rest of the headers before signing, then them after signing.

What ticket does this PR close?

Resolves #1430

Checklists

Change log

Test coverage

Documentation

(For releases only) Manual tests

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 0bd30029 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 93.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.8% (1.1% change).

View more on Code Climate.