Closed john-odonnell closed 1 year ago
Code Climate has analyzed commit 9c027b92 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 89.1% (0.0% change).
View more on Code Climate.
Desired Outcome
Enable Secrets Provider to deliver secrets with special characters/binary values.
Implemented Changes
In conjur#1989, the
/secrets
endpoint was updated to allow for the batch retrieval of secrets with binary values - adding theAccept-Encoding
header set tobase64
means Conjur will base64 encode secret values before attempting to render response JSON.We can use that functionality here to enable Secrets Provider to deliver binary/special character secrets by switching
client.RetrieveBatchSecrets()
toclient.RetrieveBatchSecretsSafe()
.Connected Issue/Story
CNJR-466
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be merged.
Changelog
Test coverage
Documentation
README
s) were updated in this PRBehavior
Security