cybergis / cybergis-compute-core

Apache License 2.0
8 stars 6 forks source link

[Bug] Models Disappear without Warning if Manifest is Invalid #91

Open alexandermichels opened 1 year ago

alexandermichels commented 1 year ago

Problem: Extremely minor issues in mainfest.jsons like a misplaced comma cause the Core to stop presenting the model as an option without notifying anyone as to why. It requires an admin checking the logs on the Core to see the problem. This might be a difficult problem to tackle because we don't own the repos for the models, model developers do.

I think the best solution is to write a simple "validate JSON" Github workflow and ask model developers to use it on their repos so they know if they push an invalid JSON. However, we are open to any suggestions.

mitkotak commented 1 year ago

I think the best solution is to write a simple "validate JSON" Github workflow and ask model developers to use it on their repos so they know if they push an invalid JSON. However, we are open to any suggestions.

Not sure whether its practical but I am thinking along the lines of using this kind of Github Action and maybe somehow automatically updating the schema.json here from core.