Fix rescuing of application errors when call_app! is used.
As a consequence of the changes that were merged in #689, errors
thrown by strategies that utilize other_phase (or more specifically
call_app!), would be caught by omniauth, causing headaches for folks
looking to have those errors handled by their application. This
should allow for errors that come from the app to pass through, while
passing errors that come from the authentication phases to the fail!
handler.
Fix for incorrect order of request_validation_phase in test_mode.
@​jsdalton gave an awesome report of the issue present in test_mode in #1033
The current implementation of mock_call was verifying the token for all requests, regardless of whether the current path is on the omniauth request path. The change was introduced recently in 1b784ff. See #1032 for details.
This creates two problems:
When test mode is on, the authenticity verification logic is run inappropriately against requests where this may not even be wanted.
The behavior varies from actual production behavior, potentially allowing bugs to be introduced by unwary developers.
Note that this bug was only present when OmniAuth was configured for test_mode and using the mock_call phases.
Allow passing rack-protection configuration to default request_validation_phase
This release now properly allows an instance of OmniAuth::AuthenticityTokenProtection (with passed in rack-protection configuration) to be used as the request_validation_phase.
Relaxed highline gem requirement to allow 3.x (#62, Thanks to @​dgholz)
1.3.3
Fixed use of unqualified ::Time that was conflicting with another
ProgressBar gem #58.
Thanks to harryloewen for the
report
1.3.2
Added ProgressBar#puts, to be able to print text to the output without
interfering with the rendering of the bar output.
#56 Thanks to
TRex22 for the suggestion in
#44.
1.3.1
Added support for passing bar options to Enumerable#with_progress
extension.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/cyclestreets/cyclescape/network/alerts).
Bumps jquery-ui-rails, rails, haml-rails, omniauth, omniauth-facebook and progress_bar. These dependencies needed to be updated together. Updates
jquery-ui-rails
from 5.0.5 to 7.0.0Changelog
Sourced from jquery-ui-rails's changelog.
Commits
413265e
Merge pull request #139 from nescalera/jquery-ui-1.13.027a942c
up gem version to 7.0.054cc600
Upgrades jquery-ui to 1.13.00b22d46
Merge pull request #121 from Borzik/fix-historyc9bdcf6
fix history, this change affected 6.0.0, not 5.0.497e9530
Merge pull request #118 from jaredbeck/patch-17b1db12
Docs: Mention how the widget files moved in 6.0.0a640214
Merge pull request #116 from alvir/patch-18f39b6d
Remove /widgets from example for stylesheets in READMEdcf13e3
Merge pull request #114 from n-rodriguez/masterUpdates
rails
from 6.1.7.8 to 6.1.7.10Release notes
Sourced from rails's releases.
... (truncated)
Commits
86864c2
Preparing for 6.1.7.10 release78cfd2f
Prepare for 6.1.7.109cd0b8f
Improvements to releaser77f0d70
Fix NoMethodError in ActionMailer block_formatb2fbbfb
Preparing for 6.1.7.9 release534b3c7
Update CHANGELOGsfaadb28
Merge pull request #16 from rails/7-0-sec-relase985f192
Avoid backtracking in ActionMailer block_format4f4312b
ActionText: Avoid backtracing in plain_text_for_blockquote_nodefb493be
Avoid backtracking in filtered_query_stringUpdates
haml-rails
from 2.0.1 to 2.1.0Commits
60dca31
Version 2.1.0aa0cde5
Wrong use ofprotected
587495c
Whitespace9f9a55b
Merge pull request #180 from BilalBudhani/haml-64d7297f
Update haml-rails.gemspec3692420
đź‘‹ Travis CI100717b
There's a newer version of actions/checkout4da8568
Newer version first5df76d3
Currently released jruby does not yet support rails 7c8839db
setup-ruby will pick newest stable jruby when simply "jruby" was givenUpdates
omniauth
from 1.9.2 to 2.1.2Release notes
Sourced from omniauth's releases.
... (truncated)
Commits
36f46c4
Prep for next releasea13cd11
Merge pull request #1122 from nschonni/jruby-hacka0b31ec
fix: conditional delegate require Rack/JRuby79d0c9a
Merge pull request #1118 from nschonni/remove-old-conditionsc160e48
Merge pull request #1102 from madogiwa0124/update-tesed-ruby-versionsb6cc0cc
chore: Remove conditions for old (J)Rubyc6e01a6
Merge pull request #1110 from nschonni/dependabot-setup4e9563f
ci: update coverals to v2fa2674c
ci: update actions/checkout to v3d050031
chore: add Dependabot for version updatesUpdates
omniauth-facebook
from 6.0.0 to 10.0.0Release notes
Sourced from omniauth-facebook's releases.
Changelog
Sourced from omniauth-facebook's changelog.
Commits
Updates
progress_bar
from 1.3.0 to 1.3.4Changelog
Sourced from progress_bar's changelog.
Commits
550d061
Update 1.3.486c3ad2
Merge pull request #63 from paul/maintenance634b3ab
Rubocop autofixes95d6856
Remove highline constraint681533f
Remove pronto workflowe57c358
Update rspec github action ruby matrixe8674aa
Add danger for rubocop501a336
Update rubocopb6b8ed1
Move dev deps to Gemfile1f7880c
Release 1.3.3Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show