Added: Generator for the full implementation

cycloidio / raws

[UNMAINTAINED] AWS Reader

MIT License

15 stars 0 forks source link

Added: Generator for the full implementation #45

Closed xescugc closed 5 years ago

xescugc commented 5 years ago

As all the implementations are the same, I've created a generator that from a configuration it's able to create the needed Interface and implementation

coveralls commented 5 years ago

Coverage decreased (-57.4%) to 27.619% when pulling e0ee45a530d7df46420470960bec5b9cd792a981 on fg-gen into 66704a8199fb2a149e53093e4fc7913fe7d3ac38 on master.

xescugc commented 5 years ago

The tests did decrease because all the generated code does not have tests, as It would mean to generate tests too, basically because the tests where also the same for everyone of the methods.

xescugc commented 5 years ago

Ok pushed the changes.

xescugc commented 5 years ago

Added test and some docs on the Readme

xlr-8 commented 5 years ago

Should we have some tests regarding already existing method? Like if 2 signatures collide because one is implemented manually the other generated?

xescugc commented 5 years ago

BTW the tests are using testify https://github.com/cycloidio/raws/issues/32

xlr-8 commented 5 years ago

LGTM! :+1: