search

cydal / tsExtract

Time series feature extraction for Supervised Learning Modeling
GNU General Public License v2.0
46 stars 8 forks source link

Change viz from matplotlib to Bokeh or Plotnine #15

Open cydal opened 4 years ago

cydal commented 4 years ago

Functions in eval produce plots currently implemented with matplotlib. This should be changed to a more aesthetically pleasing library.

vks commented 4 years ago

By aesthetically more pleasing, are you referring to the produced plot or to the code implementing the plots?

cydal commented 4 years ago

By aesthetically more pleasing, are you referring to the produced plot or to the code implementing the plots?

The produced plot. I pushed some changes today with these changes. I'll be closing off this issue.

cydal commented 4 years ago

Viz library was changed to plotnine. Plotnine was added to the list of requirements in both setup.py & setup.yaml. This works without issue for pypi but doesn't for conda as conda does not recognize plotnine.

Throws error during upload -

conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform osx-64: {"plotnine[version='>=0.0.6']"}

At the moment, pypi has version 0.0.9 but conda only has 0.0.8 which still uses seaborn