feat: [#1415] move prefix to url

cyfronet-fid / eosc-search-service

GNU General Public License v3.0

1 stars 1 forks source link

feat: [#1415] move prefix to url #1431

Closed maria-j-k closed 2 months ago

maria-j-k commented 2 months ago

prefix renamed to scope
scope is send in url params
global filters has been commented out (temporary fix -excessive calls to FiltersConfig from collections navbar)

closing #1415

github-actions[bot] commented 2 months ago

Hi @maria-j-k, thank you for raising your pull request. Check your changes at the URL.

Marcelinna commented 2 months ago

When I select the filter other disappear

Marcelinna commented 2 months ago

PR I dont see community catalog, search result

PR-12

Marcelinna commented 2 months ago

I cant click on Browse EU Resources tab

Michal-Kolomanski commented 2 months ago

@maria-j-k I still see COLLECTIONS_PREFIX value in the local storage. Its not changing so I assume that this is a default value. Please remove it

maria-j-k commented 2 months ago

@maria-j-k I still see COLLECTIONS_PREFIX value in the local storage. Its not changing so I assume that this is a default value. Please remove it

@Michal-Kolomanski this prefix is stored in the browser storage from previous run. If you remove it it won't be saved again

Marcelinna commented 2 months ago

@Michal-Kolomanski @Marcelinna when I enter https://search-2.docker-fid.grid.cyf-kr.edu.pl/ I go to https://search-2.docker-fid.grid.cyf-kr.edu.pl/search/all_collection?q=* Url is without scope despite I see that I am on tab Browse polish resources I see all collections (Bundle, Training)

Marcelinna commented 2 months ago

And it is only pr problem? When I click on service name I am redirected to https://beta.marketplace.eosc-portal.eu/services/ai4eosc-platform/information

on pr-12 I am redirected to https://marketplace-12.docker-fid.grid.cyf-kr.edu.pl//services/ai4eosc-platform/offers

Michal-Kolomanski commented 2 months ago

@maria-j-k I still see COLLECTIONS_PREFIX value in the local storage. Its not changing so I assume that this is a default value. Please remove it

@Michal-Kolomanski this prefix is stored in the browser storage from previous run. If you remove it it won't be saved again

correct

Michal-Kolomanski commented 2 months ago

And it is only pr problem? When I click on service name I am redirected to https://beta.marketplace.eosc-portal.eu/services/ai4eosc-platform/information

on pr-12 I am redirected to https://marketplace-12.docker-fid.grid.cyf-kr.edu.pl//services/ai4eosc-platform/offers

expected behaviour. PRs are connected to beta still