search

cykod / Quintus

HTML5 Game Engine
http://html5quintus.com
GNU General Public License v2.0
1.41k stars 401 forks source link

Upgrade to ES6? #172

Open frankandrobot opened 8 years ago

frankandrobot commented 8 years ago

The library is really awesome but I've noticed you guys are re-inventing the wheel in some places (for example, Q.Class.extend). Also, everything is a global which makes it hard to put classes in separate modules (files).

Have you guys thought about upgrading to ES6 or at least to AMD-style modules?

viki53 commented 8 years ago

This could be interesting, indeed. But we would have to check the compatibility issues, as some browsers don't fully comply to the ES2015 norm. I'm sure some work-arounds exist, but will they be worth it? I'll let the others explain their points of view…

ghost commented 8 years ago

I think this would make absolutely sense for development. At the end as of now the whole thing will be transpiled to es5 anyways so we dont have any browser compatibility issues.

On 1 December 2015 at 09:35, Corentin H notifications@github.com wrote:

This could be interesting, indeed. But we would have to check the compatibility issues, as some browsers don't fully comply to the ES2015 norm. I'm sure some work-arounds exist, but will they be worth it? I'll let the others explain their points of view…

— Reply to this email directly or view it on GitHub https://github.com/cykod/Quintus/issues/172#issuecomment-160894023.

akinnee commented 8 years ago

Agreed. Ideally we would write es6 classes and then transform our code into es5 using Babel in our build process.

ghost commented 8 years ago

fuck yeah!

On 13 December 2015 at 18:35, Alex Kinnee notifications@github.com wrote:

Agreed. Ideally we would write es6 classes and then transform our code into es5 using Babel in our build process.

— Reply to this email directly or view it on GitHub https://github.com/cykod/Quintus/issues/172#issuecomment-164279292.

frankandrobot commented 8 years ago

Lemme know if you guys need help.I have experience migrating legacy code to systemjs/es6.In fact, I already have a demo quintus app using systemjs and es6

    Thanks!Uriel AvalosLead Developer ConsultantChander Dhall, Inc
     ---- On Sun, 13 Dec 2015 11:35:29 -0600  notifications@github.com  wrote ----Agreed. Ideally we would write es6 classes and then transform our code into es5 using Babel in our build process.

—Reply to this email directly or view it on GitHub.