cylc / cylc-ui

Web app for monitoring and controlling Cylc workflows
https://cylc.github.io
GNU General Public License v3.0
37 stars 27 forks source link

Finalise icon colours after Vuetify 3 upgrade #1304

Open MetRonnie opened 1 year ago

MetRonnie commented 1 year ago

In Vuetify 2, icons had a default grey colour. In Vuetify 3 it is left up to font color inheritance, leading the icons without specified colours being (near-)black.

Some review comments on #1269 expressed a desire to retain the grey colour, however having gotten used to the darker colour I prefer it and feel it helps distinguish from disabled state. Though making them dark grey as opposed to near-black would be fine IMO

oliver-sanders commented 1 year ago

I took a look into some of the CSS and found some issues blocking the use of the dark theme due to hardcoded values from which icon colours are derived. Should be easy to tackle both at the same time. I have a WIP branch with most hardcoded values removed and dark theme almost there.