search

cynkra / cynkrablog

Source of the cynkra blog
https://cynkra.com/blog
0 stars 1 forks source link

Feat/fonts refactoring clean up frutiger #50

Closed talpitoo closed 7 months ago

talpitoo commented 7 months ago

@christophsax and @maelle fonts refactoring as described in https://github.com/cynkra/cynkraweb/issues/662

christophsax commented 7 months ago

@maelle is there a preview of the blog?

talpitoo commented 7 months ago

Thank you! I have a comment that is probably unrelated to font: when a sidebar item is bold, the bottom margin is higher than for non bold items.

@maelle i suggest to create a separate issue(s) for such layout inconsistencies (i can look into all those after i finish the issues at cynkraweb) so that this PR contains the font related changes only.

2) Is there a merge workflow? If i was the dev and got approvals, am i the one who should merge it?

maelle commented 7 months ago

Yes, please merge it! I opened an issue about the layout thing :smile_cat: Thanks so much for your work!