Add support for translation parameters.

marlass commented 6 years ago

Added support for parameters in translations. Unfortunately, solution presented in issue could not be done. There is a problem with naming parameters. User could provide in each language different names and that cannot be resolved automatically. So I decided just to names these params automatically: param[$i]. With this we always provide every interpolated data to be used in translation and user can later rename them in template file to his needs.

Should close #4

MaxGfeller commented 6 years ago

Thanks a lot for the PR, @marlass!

For the parameter names: i see how this is not that simple, but i'd still refrain from generating parameter names like param1 - IMO those are not really user-friendly.

Here's my suggestion:

Generate a parameter name (this is probably the trickiest part), e.g. "user.male" becomes "userMale" or "user.name" becomes "userName". Maybe you could just take the whole expression, remove all non-ascii characters and shorten it to 15 characters. E.g. user.male ? "Mr" : "Mrs" could become userMaleMrMrs. This is not always optimal but the user can still change it. Also make sure that we don't generate the same parameter name twice for a given string.
Change the CLI prompt with the text so the parameter name already gets displayed:
```
Hello text: {userMale}(user.male ? 'Mr' : 'Mrs') {userName}(user.name)
```
Then the user can just add those pre-generated placeholders

What do you think?

marlass commented 6 years ago

That solution make sense. I will hack on it later this week.

MaxGfeller commented 5 years ago

@marlass I took your changes and worked on them and they made it into 1.1.0. Thank you so much for your work!

I decided to use a solution quite similar to yours now, fell free to check it out.

marlass commented 5 years ago

Looks good. Thanks for finishing it and sorry for leaving it in uncompleted state. Glad it landed in new version.

cyon / vue-translation-manager

Add support for translation parameters. #5