search

cypht-org / cypht

Cypht: Lightweight Open Source webmail aggregator [PHP, JS]. Supports IMAP/SMTP, JMAP and soon EWS
http://cypht.org
GNU Lesser General Public License v2.1
1.01k stars 163 forks source link

Define constant for theme path #1185

Closed Shadow243 closed 3 months ago

Shadow243 commented 3 months ago

Related issue https://github.com/cypht-org/cypht/issues/1147

I tried to do it through config_gen file much like site.css but i had some issues, I then tried using theme constant for tiki standalone and the same one in Tiki Cypht Integration.

Tiki Cypht PR: https://gitlab.com/tikiwiki/tiki/-/merge_requests/5611

Shadow243 commented 3 months ago

Three Selenium tests are broken now:

in folder_list.py. I'll need time to identify where this is coming from and will correct them in another PR.

kroky commented 3 months ago

Alright, the way you do it makes sense to me. Merged it!

marclaporte commented 3 months ago

@Shadow243 This should be backported to branch 2.x, and the corresponding Tiki commit to Tiki 27.x

Shadow243 commented 3 months ago

@Shadow243 This should be backported to branch 2.x, and the corresponding Tiki commit to Tiki 27.x

Copy that.

Shadow243 commented 3 months ago

@Shadow243 This should be backported to branch 2.x, and the corresponding Tiki commit to Tiki 27.x

Done at https://github.com/cypht-org/cypht/pull/1200