search

cypress-io / action-semantic-pull-request

A Github Action that ensures that your PR title matches the Conventional Commits spec.
MIT License
0 stars 1 forks source link

Upgrade to Node.js 20 #1

Open MikeMcC399 opened 2 months ago

MikeMcC399 commented 2 months ago

What would you like?

Upgrade the action to use Node.js 20 which is the only currently supported version for GitHub Actions. See runs.using for JavaScript actions.

Why is this needed?

The action uses node12 which already reached end-of-life on Apr 30, 2022.

https://github.com/cypress-io/action-semantic-pull-request/blob/0eb081bc9c35210408951834a444794406eff6f8/action.yml#L4-L5

GitHub Actions forces the use of node20.

A secondary issue is that package.json is locked to using Node.js 16.x which reached end-of-life on Sep 11, 2023.

https://github.com/cypress-io/action-semantic-pull-request/blob/0eb081bc9c35210408951834a444794406eff6f8/package.json#L44-L46

Other

MikeMcC399 commented 2 months ago

The upstream repo https://github.com/amannn/action-semantic-pull-request has already resolved this issue. It would probably be sufficient to sync the fork with the upstream main branch.

MikeMcC399 commented 2 months ago

I would expect this to be resolved by clicking on the Sync fork button, which should be displayed for anybody with write access to the fork.

image

image

MikeMcC399 commented 1 month ago

I don't believe this can be resolved by a PR from an external contributor's fork, since it needs tags creating as well.

If somebody from Cypress.io would like to respond and/or click on Sync fork we can see how far that takes us.