cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
46.66k stars 3.16k forks source link

Chore: Require @packages/example to be reviewed before deployment #29147

Open cacieprins opened 5 months ago

cacieprins commented 5 months ago

Current behavior:

@packages/example deploys directly to production example.cypress.io as soon as the deploy command executes, via the gh-pages tool.

As a stopgap to prevent outages:

In the future:

MikeMcC399 commented 5 months ago

I also discovered that running

yarn workspace @packages/example deploy

from a fork deploys to the fork's gh-pages branch. The web's structure is however not set up to run correctly from a fork, Only the index.html displays correctly. Navigation to other pages does not work and CSS formatting does not work on other pages either.

That may become irrelevant if the deploy process is changed. If not it should be noted in the README.

MikeMcC399 commented 5 months ago

Possibly something like Percy could be used for visual comparison of pending changes to https://example.cypress.io ?

MikeMcC399 commented 5 months ago

Current drawbacks