cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
46.77k stars 3.17k forks source link

3.5.0 - CypressError: Timed out retrying: Cannot read property 'defaultView' of null #5449

Closed ilituchy closed 4 years ago

ilituchy commented 4 years ago

When I attempt to use a .select() on a <select> object, I am getting the posted error.

This is only the case when attempting to select something from the dropdown that DOES exist on the list. If I attempt to select a value that doesn't exist, I get the standard

Cypress error "CypressError: Timed out retrying: cy.select() failed because it could not find a single <option> with value or text matching...". 

I have previously been using this exact test successfully, and something must have changed causing it to error out. I find that even if I comment out this portion, similar errors follow with other commands later in the test.

This is the stack trace for the error.

CypressError: Timed out retrying: Cannot read property 'defaultView' of null
    at Object.cypressErr (http://app.locals/__cypress/runner/cypress_runner.js:104836:11)
    at Object.throwErr (http://app.locals/__cypress/runner/cypress_runner.js:104791:18)
    at Object.throwErrByPath (http://app.locals/__cypress/runner/cypress_runner.js:104823:17)
    at Object.retry (http://app.locals/__cypress/runner/cypress_runner.js:96197:16)
    at retryActionability (http://app.locals/__cypress/runner/cypress_runner.js:84998:19)
From previous event:
    at tryFn (http://app.locals/__cypress/runner/cypress_runner.js:96655:21)
    at whenStable (http://app.locals/__cypress/runner/cypress_runner.js:96690:12)
    at http://app.locals/__cypress/runner/cypress_runner.js:96240:16

I cannot seem to find anything called defaultView except within jQuery itself. I have tried searching this space for an answer, but cannot seem to figure out what the deal is.

The code that causes this error is:

cy.get('#inputDoctors').select(physicianName);

The get is successful, and I can confirm that element exists and the value is a valid option.

Steps to reproduce:

I believe that this error is somehow project internal, which for many reasons cannot be completely shared. However, I will create a very simple idea of what is going on:

<select id="inputDoctors>
  <option value="Doctor1">apples</option>
  <option value="Doctor2">oranges</option>
  <option value="Doctor3">bananas</option>
</select>
cy.get('#inputDoctors').select('Doctor1'); --> Fails with defaultView Error
cy.get('#inputDoctors').select('Doctor15'); --> Fails with cannot find value error

I understand it may be hard to help debug, but really anywhere you can point us to to start debugging this error is greatly appreciated.

Versions

Cypress: 3.5.0

jennifer-shehane commented 4 years ago

Hey @ilituchy, you mentioned I have previously been using this exact test successfully, did you update to 3.5.0? Can you run the same code in 3.4.1 and see if this error displays. Thank you!

jennifer-shehane commented 4 years ago

Unfortunately, the example provided does not reproduce this error on our side in Chrome or Electron during cypress open.

We'll need a reproducible example in order to track down what exactly is causing this error.

Screen Shot 2019-10-24 at 1 04 28 PM

There are a few places where we are looking for defaultView within the Cypress code, mostly during clicking. Some places like el.ownerDocument.defaultView, likely there's something about your HTML that is causing this to evaluate as undefined

https://github.com/cypress-io/cypress/blob/develop/packages/driver/src/cy/mouse.js#L581

ilituchy commented 4 years ago

We have updated to 3.5, and still get the issue. We were able to add some wait statements that solved a few, but still run into issues with others. It is not always a select element, but can be input or anything else. Seems to just randomly have this issue.

My guess is that for some reason the elements it errors on are re-rendering perhaps? Because I was able to fix a few, I'm assuming that timing might be the issue. However, it wasn't before.

Do you have any good suggestions on setting delays / promises / waits for elements to be rendered? Obviously I know the standard methods, but they don't seem to be working always.

ashley-maiden commented 4 years ago

I am also seeing CypressError: Timed out retrying: Cannot read property 'defaultView' of null in Cypress 3.5.0 when interacting with an iframe input. The same code does not generate an error in Cypress 3.4.1. I know iframes aren't natively supported right now but any tips would be helpful.

Custom command to interact with iframe elements (this still successfully selects buttons in the iframe):

Cypress.Commands.add('iframeElement', (selector) => {
  cy.log(selector)
    .get(`body > iframe`, { log: false })
    .should(iframe => expect(iframe.contents().find(selector)).to.exist)
    .then(iframe => cy.wrap(iframe.contents().find(selector), { log: false }))
})

Code to enter username in the username in the iframe input field :

cy.iframeElement('#username')
    .type('user_good') 
#username
ilituchy commented 4 years ago

@ashley-maiden we are having the same error with iframes as well! We were able to get it to work in the past, most likely on an older version.

jorisre commented 4 years ago

Hi, got same error with stripe form during payment. Cypress can fill 2 fields of 3 and throw this error

daniel-ogunnaike commented 4 years ago

@ashley-maiden I am also having the same error when accessing an iFrame on 3.5.0 worked fine on 3.4.1 I'm not sure if the issue is the Electron bump or jQuery upgrade

zitegeist commented 4 years ago

yeah I've been getting the same issue too in my Stripe payment iFrames, the tests were fine and after the upgrade to 3.5.0 they just stopped working, rolled back to 3.4.1 and they work perfectly again, might be right with the JQuery upgrade @daniel-ogunnaike

zbynek commented 4 years ago

I'm not sure if the issue is the Electron bump or jQuery upgrade

Probably not Electron, the same failure happens in Chrome.

daniel-ogunnaike commented 4 years ago

I'm not sure if the issue is the Electron bump or jQuery upgrade

Probably not Electron, the same failure happens in Chrome.

Yeah, my money is on the jQuery upgrade

sigujun commented 4 years ago

Same for me, Tests are breaking in 3.5.0 but work fine in 3.4.1 ‘CypressError: Timed out retrying: Cannot read property 'defaultView' of null’

kmckee commented 4 years ago

Same issue here. This test fails on 3.5.0 with the above error. I rolled back to 3.4.1 and it passes:

describe("Storybook", () => {
  beforeEach(() => {
    cy.visit("http://airbnb.io/react-dates/");
  });
  context("DateRangePicker", () => {
    it("should visit the default story in this collection", () => {
      cy.get('a[title="default"]').click()
      cy.get("#storybook-preview-iframe").then($iframe => {
        const doc = $iframe.contents();
        iget(doc, "#startDate").click();
        iget(doc, "#root > div > div:nth-child(2) > div > button").should(
          "have.text",
          "Show Info"
        );
      });
    });
  });
});

function iget(doc, selector) {
  return cy.wrap(doc.find(selector));
}
pocketcolin commented 4 years ago

Adding to this thread, I also just upgraded to 3.5 and can no longer complete Stripe payment iFrames.

cy.get('iframe[name^="__privateStripeFrame"]').then($iframe => {
    const $body = $iframe.contents().find('body')
    cy.wrap($body)
        .find('input[name="cardnumber"]', { timeout: 10000 })
        .type('4242')
        .type('4242')
        .type('4242')
        .type('4242')
})

Returns the same error:

CypressError: Timed out retrying: Cannot read property 'defaultView' of null
realtebo commented 4 years ago

OMG Same problem, same version, same use case. Damn...

The strange this is that find works well. What fails is the type(). Also, click() fails in this situations.

I'll downgrade to 3.41.

realtebo commented 4 years ago

Yes, I confirm that with version 3.41 Stripe Iframes works well!

adventmedia commented 4 years ago

I had the same problem with Stripe iframes with 3.5, reverted to 3.4.1. What might be odd is that our implementation has separate iframes for the 3 inputs - first one works, next fails

Akryum commented 4 years ago

Also happens to us in 3.5: https://github.com/vuejs/vue-devtools/blob/7e63da196e51083df51aed10eda8f1d7f51bc82a/cypress/integration/components-tab.js#L83-L85

(Not using an iframe for the vue-devtools is not really an option.)

bencatjakub commented 4 years ago

I'm experiencing the same behaviour after upgrading to 3.5.0 and it's working on 3.4.1

Please fix this.

kuceb commented 4 years ago

I was able to reproduce and am working on a fix

cypress-bot[bot] commented 4 years ago

The code for this is done in cypress-io/cypress#5520, but has yet to be released. We'll update this issue and reference the changelog when it's released.

pazjing commented 4 years ago

We have the exactly the same issue on iframe (test code works fine in 3.4.1 , but fail in 3.5.0) Waiting for the fix.

WinstonN commented 4 years ago

Hello, I am seeing the same issue in 3.6.0 - downgrading to 3.4.1

alexsegura commented 4 years ago

@WinstonN are you sure you are using 3.6.0? The issue disappeared completely after upgrading for me 🤔 Here is the code I'm using to manipulate the iframe

https://github.com/coopcycle/coopcycle-web/blob/9311d2d26f44861ddbf12a5e266f7b2802872205/cypress/integration/checkout.spec.js#L94-L114

jennifer-shehane commented 4 years ago

@WinstonN Please open a new issue detailing exactly how to reproduce the warning you are seeing - this bug for this situation has been fixed.

cypress-bot[bot] commented 4 years ago

Released in 3.6.0.

rohitkadam19 commented 4 years ago

Was facing this issue with 3.5.0 but resolved in 3.6.1 version 👍

realtebo commented 4 years ago

I definitively love you so much.

I confirm all about sentry iframes are working well in 3.6.1. Both 3.50 and 3.6.0 were NOT working.

Thanks more than a lot.