cytomining / cytominer

Methods for Image-Based Cell Profiling
https://cytomining.github.io/cytominer/
Other
49 stars 28 forks source link

Issues/52 #75

Closed mrohban closed 7 years ago

mrohban commented 7 years ago

added extract_subpopulations function which uses k-means on both treatment and control single cell data to identify the subpopulations and assign each cell to those.

mrohban commented 7 years ago

updated the base master and there was no conflict.

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@abe4c4a). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage          ?   85.07%           
=========================================
  Files             ?       14           
  Lines             ?      355           
  Branches          ?        0           
=========================================
  Hits              ?      302           
  Misses            ?       53           
  Partials          ?        0
Impacted Files Coverage Δ
R/extract_subpopulations.R 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abe4c4a...27ec8cd. Read the comment docs.

mrohban commented 7 years ago

updated to the version 6.0.1 and re-ran devtools::document().

shntnu commented 7 years ago

Great! It would need some bit of refactoring to avoid using CellProfiler specific terminology (e.g. Metadata_*) but that should be straightforward using the approach described in http://dplyr.tidyverse.org/articles/programming.html. We can pair program next week and get this done