czbiohub-sf / Rapid-QC-MS

Realtime quality control for mass spectrometry data acquisition
https://czbiohub-sf.github.io/Rapid-QC-MS
Other
15 stars 2 forks source link

Sanitize instrument names #91

Closed InventoRyAlpaca closed 12 months ago

InventoRyAlpaca commented 12 months ago

Instrument names can have any character in them currently, including characters that can't be in file names like : or < and >.

Setup works normally, but trying to start a run produces NotADirectory errors because of a mismatch between instrument name and the instrument .db file name on disk.

InventoRyAlpaca commented 12 months ago

https://github.com/czbiohub-sf/MS-AutoQC/commit/a9fe18194d29cb07c4e3c9118e4fe89f12e32590 added pattern matching to instrument name to limit input to alphanumeric, spaces, underscores, and dashes. Looked for a tooltip or some other method of better user feedback, but haven't found one.