search

czerwonk / junos_exporter

Exporter for devices running JunOS to use with https://prometheus.io/
MIT License
198 stars 81 forks source link

Add multi routing engine support for the "environment" module #135

Closed AKYD closed 3 years ago

AKYD commented 3 years ago

(This will close: https://github.com/czerwonk/junos_exporter/issues/66)

Add tests Extract PEM statistics

! I do not have access to a satellite setup so the satellite test is not tested (not sure I understand what it does).

AKYD commented 3 years ago

@czerwonk did you by any chance test the satellite behavior, or just eyeballed the code?

I'm referring to : https://github.com/czerwonk/junos_exporter/pull/135/files#diff-ef524dc00c4aca60ce490b02fb8e134018de8ab652ca69b61f2994edd7db41a3R103

4xoc commented 3 years ago

@czerwonk did you by any chance test the satellite behavior, or just eyeballed the code?

I'm referring to : https://github.com/czerwonk/junos_exporter/pull/135/files#diff-ef524dc00c4aca60ce490b02fb8e134018de8ab652ca69b61f2994edd7db41a3R103

Using satellite panics the exporter. I've created #139 that fixes this small typo.