search

czue / celery-progress

Drop in, configurable, dependency-free progress bars for your Django/Celery applications.
MIT License
472 stars 90 forks source link

Websocket tweaks #19

Closed czue closed 5 years ago

czue commented 5 years ago

@EJH2 any feedback on these changes before I merge them and push to pypi?

czue commented 5 years ago

Going to merge and roll this out but let me know if you have any other suggestions @EJH2

EJH2 commented 5 years ago

Sorry! I must have missed the email for this. One extra thing I would note in the README is the instructions on installing the redis/rabbitmq dependencies, I.E. pip install celery-progress[websockets,redis] or celery-progress[websockets,rabbitmq]. One thing that I've recently come across is this note in the Sentry docs, which references this issue. I feel like it might be worth mentioning, but it is up to you on how you want to address this.

czue commented 5 years ago

Updated the README in afd0616fbc299846a6c2ab124ed726bcff239c34 (hopefully I got the language right).

I'm not familiar enough with the sentry/channels issue you mentioned to know how to talk about it, but if there's anything you think should be added to the readme feel free to submit a PR.

Thanks again for the contribution