search

d-e-s-o / debuginfod

A crate for interacting with debuginfod servers.
Apache License 2.0
3 stars 1 forks source link

Allow already formatted build IDs #1

Closed javierhonduco closed 1 month ago

javierhonduco commented 1 month ago

Currently build ids have to be a byte slice, which makes sense if you are obtaining them from the section where they are stored in the ELF files. As the debuginfod servers required the formatted representation, fetch_debug_info formats them before issuing the HTTP request.

This is inconvenient for projects where the formatted build id is already stored, as we would have to convert back to raw bytes and this crate would once again convert to the formatted representation, so this commit generalises build ids to their own enum.

Test Plan

Added the already formatted build id variant to the integration tests.

codecov-commenter commented 1 month ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

javierhonduco commented 2 weeks ago

Hi Daniel! Would really appreciate if you could cut a release for this feature 🙏

d-e-s-o commented 2 weeks ago

Hi Daniel! Would really appreciate if you could cut a release for this feature 🙏

It sounds as if another breaking change is coming with https://github.com/d-e-s-o/debuginfod/issues/8. Can we wait for that to land first?

d-e-s-o commented 2 weeks ago

FYI, 0.2.0 is out.