Swimlane Date column support

[norbertbede]

i want to define new swimlane rule, by date column. ATM this is not possible, @d-ruiz check the code.

solution: add support for date, datetime column types i.)allow select ii.)allow format the date by sql function. eg. to_char(timestamp_column, 'YYYY-MM')

[PeterTakacs300]

Hi @d-ruiz,

we have created a POC solution for date Swimlines.

Demo video: https://user-images.githubusercontent.com/93127072/224946227-1494a1cf-83a3-4b49-a775-75c2f1666243.mp4

Setup: Update Validation Rule in System (AD_Val_Rule_ID=1000351):

• Update Description: Only columns with date, date+time, table, table direct, search or list datatypes
• Update Validation Code: AD_Column.AD_Table_ID=@AD_Table_ID@ AND AD_Column.AD_Reference_ID IN (15,16,17,18,19,30)

Patch: kanban_date_swimlines.patch

Currently it has two main issues that are hardcoded:

1. we are not able to generate the time series based on a Date range kanban parameter (currently hardcoded to now()-interval '7 days', now()+interval '14 days')
2. we are not able to set the swimlane grouping time unit, currently hardcoded to days
   • possible solution is to add a similar column as Time Group By which we have implemented on Charts (it is not in iDempiere) - you would be able to select the time unit (Year, Month, Week, Day, Hour...) for which you want to group the cards into swimlanes

[PeterTakacs300]

Hi @d-ruiz.

We would like you to review the attached patch (it could be considered as draft) which contains the following improvements:

• support for generating swimlanes from date parameters
• connecting the swimlane’s range to the kanban parameter - changing e.g. a date range parameter causes dynamic redrawing of the swimlanes (if IsDefault='Y')

Notes about the known issues:

• the solution of sending the date from-to args into the KanbanSQLUtils.getColumnSQLStatement method is probably not generic enough, they should be sent into KanbanSQLUtils.getKanbanPreparedStatement method as parameters
• currently when changing the value of a kanban parameter, the kanban cards are loaded multiple times (MKanbanBoard -> refreshCards() and WKanbanBoard -> createKanbanBoardPanel()) - I’ve added that to the latter method because the swimlanes needs to be refreshed before loading the cards + the initParameters() method should be called before initialising swimlanes, because the swimlanes needs to know the current parameter values

patch: kanbanSwimlanes.patch

[d-ruiz]

Hi @PeterTakacs300, as mentioned before, the pull request is quite big and the second commit changes things that the first commit adds, so it would be very hard for me to review this properly and I don't have that time right now.

As I suggested before, it would be easier if you could split the pull requests into smaller commits. Basically this structure.

What do I need to change and what is missing?

What do I need to refactor to accomplish that? -> Refactor commit

With the refactor what do I need to add to make it work? -> Commit with the new feature

If you mix both things in one single commit, it becomes really hard for the reviewer to analize potential side effects and so on.

Could you split it into, refactoring the methods that were already there and explaining why they need to be refactor, and then adding the new functionality on top (Clean without commits changing what you added before)

Thanks, Diego