search

d0k3 / GodMode9

GodMode9 Explorer - A full access file browser for the Nintendo 3DS console :godmode:
GNU General Public License v3.0
2.07k stars 192 forks source link

Embed the VRAM tar data in the ARM9 executable #824

Closed Wolfvak closed 11 months ago

Wolfvak commented 11 months ago

As a follow up to some of my comments on #816, this PR removes the extra FIRM section that was used as the "VRAM drive" (huge misnomer for a while but whatever, my bad) and instead embeds it as part of the ARM9 section, compiled as part of the arm9.elf binary.

Wolfvak commented 11 months ago

@danny8376 any comments on this? iirc you were testing the limits of the VRAM drive sizes, this might help you get larger drives bundled in GM9

danny8376 commented 11 months ago

fine with it? I do have two different cases for large vram drive one is the normal-ish one that can fit within arm9 mem. for that, this will surely make it easier as there's no need to tweak offset manually anymore (but i'm actually fine with both way as tweaking the offset isn't that annoying) another one is well over 1MiB, like full 6MiB VRAM or even more but that's totally abnormal and hacky and need way more changes, so not really related here also, the change isn't that huge, so doesn't affect that much

d0k3 commented 11 months ago

Late to the party, I've been on vacation with no access to a PC (aka a digital detox :)). Thanks for the update, @Wolfvak ! And, of yourse, looks good to me.