search

d8-contrib-modules / cloudflare

Cloudflare Module for Drupal
16 stars 14 forks source link

Any cache tags purged in Drupal 8 should also be purged on CloudFlare. #17

Closed wimleers closed 9 years ago

wimleers commented 9 years ago

Please disable PHPCS ASAP.

From testbot:

FILE: ...dflare/src/EventSubscriber/CloudFlareCacheTagHeaderGenerator.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------

Because

/**
 * @file
 * Contains \Drupal\cloudflare\EventSubscriber\CloudFlareCacheTagHeaderGenerator.
 */

But that is the convention. We put it on one line, no matter how long. So PHPCS is not fit to work with Drupal 8 code.

You'll find dozens of examples of this in D8 core.

aweingarten commented 9 years ago

@wimleers, For expediency here I am going to submit a separate PR to dial it down PHPCS to allow warnings to pass through.

It looks like someone else is having an identical issue: https://www.drupal.org/node/2530920