daattali / ggExtra

📊 Add marginal histograms to ggplot2, and more ggplot2 enhancements
http://daattali.com/shiny/ggExtra-ggMarginal-demo/
Other
383 stars 45 forks source link

R CMD check results in NOTE #126

Closed crew102 closed 6 years ago

crew102 commented 6 years ago

geom_histogram2: no visible binding for global variable ‘..density..’

IndrajeetPatil commented 6 years ago

This should help get rid of this note-

# defining global variables and functions to appease R CMD Check

utils::globalVariables(names = c(".",
                                 "..density..",),
                       package = "ggExtra",
                       add = FALSE)
crew102 commented 6 years ago

@IndrajeetPatil, can you open a PR with this added somewhere in https://github.com/daattali/ggExtra/blob/master/R/ggMarginal.R?

IndrajeetPatil commented 6 years ago

You can literally copy this code into a new global_vars.R file in the R folder and that's that! (e.g. https://github.com/IndrajeetPatil/ggstatsplot/blob/master/R/global_vars.R)

I have never forked a repo, so a bit wary of doing that.

daattali commented 6 years ago

@IndrajeetPatil we can do that it's not a problem. But because it is such a trivial change, it would be a great first experience at learning how the open collaboration works on github. Are you sure you don't want to look into making the PR yourself? Thanks for the tip regradless

daattali commented 6 years ago

I should add: you can't do any damage. You can try and learn from the process, but no damage will be done

IndrajeetPatil commented 6 years ago

Thanks for the encouragement :)

Created a PR; let's see if this works.

daattali commented 6 years ago

Fixed