search

daattali / ggExtra

📊 Add marginal histograms to ggplot2, and more ggplot2 enhancements
http://daattali.com/shiny/ggExtra-ggMarginal-demo/
Other
383 stars 45 forks source link

Add unit tests to ggExtra #47

Closed crew102 closed 7 years ago

crew102 commented 7 years ago

This PR does three things:

  1. Slightly alters ggMarginal's print method so we don't get leading blank pages when printing to non-interactive devices (e.g., pdfs, pngs, svgs, etc.)
  2. Allows the user to completely control the appearance of the plot's title (closes #46)
  3. Sets up visual tests for the package using the vdiffr framework. Right now it only tests under the current version of ggplot2, but it's set up to be easy to test under multiple versions (closes #41)
daattali commented 7 years ago

Thanks for going the extra mile! I do recall a couple people mentioning to me over time about that first-page-blank issue but it never made it into an issue so I forgot about it!

daattali commented 7 years ago

This PR fixes #48

crew102 commented 7 years ago

I have made the changes that we talked about in this updated PR. I had to go back and re-work the title accession because I didn't realize that ggplot2 keeps the title and subtitle in separate grobs.

daattali commented 7 years ago

Thank you, great work!