This PR adds code/figures to test ggMarginal (and some ggplot2 internals) under multiple versions of ggplot2, which should close issue #42.
Two notes:
The current framework requires that you install the various versions of ggplot2 two times when you run devtools::test() - one time for running the visual reg. tests in test-ggMarginal.R and one time for running the tests of ggplot2 internals in test-ggplot2-internals.R. We could wrap the tests up in a single function call and thus not have to download the various versions multiple times, but since it doesn't take long to download ggplot2, I figured it's not worth it.
"latest" can be added as a ggplot2 version in runMarginalTestsApply and runInternalTestsApply. This will run the tests using the latest version of ggplot2 from github. Currently the tests do not pass under "latest," as per issue #38. I will add "latest" to the calls when I merge/push the refactor branch.
daattali
commented
7 years ago
This PR adds code/figures to test
ggMarginal(and someggplot2internals) under multiple versions ofggplot2, which should close issue #42.Two notes:
The current framework requires that you install the various versions of
ggplot2two times when you rundevtools::test()- one time for running the visual reg. tests in test-ggMarginal.R and one time for running the tests ofggplot2internals in test-ggplot2-internals.R. We could wrap the tests up in a single function call and thus not have to download the various versions multiple times, but since it doesn't take long to downloadggplot2, I figured it's not worth it."latest" can be added as a
ggplot2version inrunMarginalTestsApplyandrunInternalTestsApply. This will run the tests using the latest version ofggplot2from github. Currently the tests do not pass under "latest," as per issue #38. I will add "latest" to the calls when I merge/push the refactor branch.