daem-on / wtherion

A web-based Therion map editor
https://daem-on.github.io/wtherion/
MIT License
17 stars 2 forks source link

☂️ Fix importer parsing errors #12

Open daem-on opened 2 years ago

daem-on commented 2 years ago

Umbrella issue for #11, #9, #7

The wtherion importer for TH2 files makes some assumptions based on the thbook specifications, some of which are incorrect. Not everything follows the same patterns and maybe the whole option parser needs to be rewritten.

CaverBruce commented 1 year ago

Checking beta version image

Imported to WT beta a th2 created by XTherion, saved in WT, exported to th2 then compared to original th2. The file contained 7 scraps, 4 xvi files and 1 scanned image. It is more complicated than is typical for me - usually I only load 1 xvi or scanned image. Have attached both versions of the file.

A few things apparent:

3-HawkesPlan-exported from WTherion.th2.txt 3-HawkesPlan-created with XTherion.th2.txt

daem-on commented 1 year ago

@CaverBruce Thanks! Seems like the fixes I implemented were not at all enough, but these issues should be fixable. Like I said, I don't have a lot of time right now, maybe next week I'll be able to work on this. Thank you again for the testing and feedback.