search

daerduoCarey / SpatialTransformerLayer

Other
181 stars 97 forks source link

Update + whole caffe #3

Open matthieudelaro opened 8 years ago

matthieudelaro commented 8 years ago

Hi,

thanks for your implementation, it's been really useful for my recent project. I wonder though: why do you share only the files that you modified, instead of the whole caffe?

I took me some time to insert it into up-to-date caffe master (put files where they belong, modify caffe.proto, update your files to the structural changes of Caffe), so I share the final code for those who would be interested : https://github.com/matthieudelaro/caffeBVLCplus/tree/stn. It's an up-to-date, ready to compile caffe, including STN, and un-blocked CPU implementation (which leads me to another question: why did you disable the CPU implementation?). I'll consider working on a clean PR if your willing to merge it.

daerduoCarey commented 8 years ago

Thank you greatly for your work on this.

For your first question, I think it's easier to only share the files that I modified/added because you can merge them down without too much conflicts. Because my version of Caffe is not the latest one, my upload of other Caffe files may not be so useful.

For the second question, thanks so much for cleaning up my code and making it into new version of Caffe. The reason why I dropped the implementation for CPU version is that I found that I will mostly use my GPU version in my experiments and the CPU version is not fine-tuned and speeded up so much. So, I didn't share it.

Thank you again for your great job.