search

dafny-lang / libraries

Libraries useful for Dafny programs
Other
43 stars 25 forks source link

fix: Partially fix nightly build for 4.2 #131

Closed robin-aws closed 1 year ago

robin-aws commented 1 year ago

Only fixes the fact that the top-level workflow looks green even though the job fails (https://github.com/dafny-lang/libraries/actions/runs/5506948866) and adds --compile-suffix when necessary.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

robin-aws commented 1 year ago

I'm on board with merging this even though the 4.1 tests fail, to make sure that our next PR has to be one to fix those tests. However, do the settings on this repository allow us to merge a PR with failing tests?

When I cut this PR I thought I was just making progress on working against the latest nightly, but now I see that 4.1 has never worked. :(

I'll merge this by temporarily changing the branch protection rules, just because I think turning the nightly build red as it should be is important for visibility as well.

robin-aws commented 1 year ago

I've re-added 4.1 as a required check, so the CI is effectively broken on this repo now as intended. :)