Closed cpitclaudel closed 1 year ago
I think I have addressed everything, either with a direct fix (🚀) or by leaving a comment (👀). I will check that verification passes in CI tomorrow.
CI is good; @MikaelMayer , I'll leave this for you to merge :)
I'll do a 2nd review of the PR (mostly around usability/documentation/etc.) but will rely on @fabiomadge's assistance to get this verifying on Dafny 4.0 as well (since by the time this merges the repo will be verifying on that too: #104)
These improvements should be part of src/dafny -- not (or at least not just) src -- src/dafny is the reorganized library we are trying to move forward with.
@davidcok - tracking the work to ensure we migrate everyone to src/dafny
here: https://github.com/dafny-lang/libraries/issues/119. I think it would be unfriendly to only add new functionality in the new copy at this point.
The library is documented in
JSON/README.md
, and there is a tutorial inJSON/Tutorial.dfy
.