search

daft-engineers / vocoder

Open source vocoder designed for the Raspberry Pi.
https://daft-engineers.github.io/vocoder/
Mozilla Public License 2.0
9 stars 0 forks source link

Test framework #36

Closed MarkAHarley closed 1 year ago

MarkAHarley commented 1 year ago

This updates the project CMake to integrate Google Test unit testing.

Build in the root directory with

cmake -S src/ -B build cmake --build build

Run tests in the build directory with

ctest

MHCooke commented 1 year ago

I see that filter.hpp was deleted, was that deliberate?

MarkAHarley commented 1 year ago

I see that filter.hpp was deleted, was that deliberate?

Yes, it is not relevant to this branch and also I've replaced it with filter.h (I don't think .hpp is necessary)

MHCooke commented 1 year ago

I see that filter.hpp was deleted, was that deliberate?

Yes, it is not relevant to this branch and also I've replaced it with filter.h (I don't think .hpp is necessary)

Ok, I don't see filter.h in this patchset though. I'd rather leave that out of the testing framework commit personally. That can be sorted somewhere else imo

MarkAHarley commented 1 year ago

I see that filter.hpp was deleted, was that deliberate?

Yes, it is not relevant to this branch and also I've replaced it with filter.h (I don't think .hpp is necessary)

Ok, I don't see filter.h in this patchset though. I'd rather leave that out of the testing framework commit personally. That can be sorted somewhere else imo

Yes, I left it out of this patchset intentionally, it will be introduced with the filter branch.

Jambls commented 1 year ago

It's best practise to leave it alone in commits that don't concern it, so if you can be bothered, you should move the deletion of the .hpp to the commit or pull request that adds the new one.

MarkAHarley commented 1 year ago

It's best practise to leave it alone in commits that don't concern it, so if you can be bothered, you should move the deletion of the .hpp to the commit or pull request that adds the new one.

Yeah I just realised what I did wrong, was confused because I forgot filter.hpp was already in main. I can get rid of this change before the pull request goes through.