search

daft-engineers / vocoder

Open source vocoder designed for the Raspberry Pi.
https://daft-engineers.github.io/vocoder/
Mozilla Public License 2.0
9 stars 0 forks source link

Check those headers #53

Closed Jambls closed 1 year ago

Jambls commented 1 year ago

Updated checks.sh to make it check headers Omitted the llvm-header-guard check because making it make sense would have been a lot of effort.

Closes #46

MHCooke commented 1 year ago

Do you have a separate patch for #55 , or is there is a missing commit here

Jambls commented 1 year ago

.clang-tidy has been emptied

It hasn't, I think github is bugging out because the file has been changed twice, but over the whole PR it's back to where it was.

Jambls commented 1 year ago

Do you have a separate patch for #55 , or is there is a missing commit here

I was gonna do a separate PR, it's a separate issue and separate problem. Happy to combine them if you want.

Jambls commented 1 year ago

Now that I've moved the header files, I should check cmake to find out if they'll still be found by it

MarkAHarley commented 1 year ago

Why does each include file need a subdir now that there is an include folder? i.e it seems unnecessary to have include/filter/filter.hh when you could just have include/filter.hh

MHCooke commented 1 year ago

Why does each include file need a subdir now that there is an include folder? i.e it seems unnecessary to have include/filter/filter.hh when you could just have include/filter.hh

@Jambls do you have any thoughts on this? I was going from my previous (python) experience and putting everything in sub dirs, but if we aren't going to have subclasses of things, it does seem sensible to keep them all in one place.