search

dagargo / overwitch

JACK client for Overbridge devices
GNU General Public License v3.0
142 stars 18 forks source link

Gracefully handle when device is disconnected #20

Closed szszoke closed 2 years ago

szszoke commented 2 years ago

Hello!

Overwitch should handle when a device is disconnected gracefully. Today it locks up and prints a lot of messages like this:

ERROR:jclient.c:214:(jclient_o2j): o2j: Unexpected frames with ratio -540517.047517 (output 0, expected 1024)
dagargo commented 2 years ago

I've just pushed 1f1a69597d555b2b5007d085deb30bc5f3d30978, which solves this.

But, do you mind testing this yourself too? Let me know if everything works as intended.

szszoke commented 2 years ago

I did some testing and I think it works great. There were no nasty sounds this time, just some error messages about the device possibly being disconnected and then Overwitch shut down.

dagargo commented 2 years ago

But I've just realized that Ctrl+C doesn't work. I'll take a look at it.

dagargo commented 2 years ago

Ctrl+C fixed in 9b1bbd80b5551e889e9552e0ee61a9007c163258.

I'm closing this as solved. Feel free to reopen this if needed.