search

dagger / dagger

An engine to run your pipelines in containers
https://dagger.io
Apache License 2.0
11.54k stars 620 forks source link

Directory.glob: make pattern optional #8835

Open shykes opened 1 month ago

shykes commented 1 month ago

Directory.glob() should be callable without arguments. The intuitive default for pattern is **, which will match everything.

jedevc commented 1 month ago

Making it optional means that the standard way of calling it would now require an opts struct - given that's probably the general case, I think it makes more sense to optimize that case for simplicity.

(note, this would also be a breaking change)

shykes commented 3 weeks ago

Making it optional means that the standard way of calling it would now require an opts struct

Only in Go :)

(note, this would also be a breaking change)

Only in Go :)