search

dagster-io / dagster-cloud

Unify all your data tools into a productive, enterprise-grade platform.
https://dagster.io/cloud
25 stars 15 forks source link

Fix incompatible signature #20

Closed aksestok closed 6 months ago

aksestok commented 6 months ago

GraphQLEventLogStorage.get_latest_materialization_events overrides the EventLogStorage.get_latest_materialization_events in an incompatible way, resulting in validation errors when running in the cloud vs. local dagster dev development.

See interface: https://github.com/dagster-io/dagster/blob/456494d07413ebc781c08bcdfb22b69e419410d1/python_modules/dagster/dagster/_core/storage/event_log/base.py#L368-L372

(There are many more incompatible overrides in this file, but this is the only one that bothers us for now.)

rexledesma commented 6 months ago

Closing this PR, as https://github.com/dagster-io/dagster-cloud is a read-only repository. We'll make the necessary changes in our internal repository so that these types are fixed in the future.