search

daheise / simrate_control

A 'set it and forget it' utility to increase and decrease sim rate while following a flight plan. Provides time compression while in stable flight.
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Some informative messages can be duplicated #31

Closed daheise closed 3 years ago

daheise commented 3 years ago

Some functions, like SimrateDiscriminator.is_ap_active() may get called twice in a single data output frame.

SimrateDiscriminator.is_ap_active() gets called here and here within a single loop, leading to the same messages being sent to the UI twice.

daheise commented 3 years ago

While not the best solution, I think I am just going to de-duplicate message at the time they get written to the screen, i.e. self._messages = list(OrderedDict.fromkeys(self._messages)) in ScCurses._write_messages_to_screen().

daheise commented 3 years ago

@woodstock327 Would you be willing to test the flaps branch and let me know if it resolves the duplicated messages?

ghost commented 3 years ago

Absolutely, though I won’t get to it before tomorrow

daheise commented 3 years ago

This has been pulled into main. Let me know if it’s not working.

ghost commented 3 years ago

Didn't manage to do a full flight, but I did a quick test run and everything works great. The message duplication is gone, and I tried the new flaps detection which seems to work fine even in the DC-6. Also the new waypoint toggle is cool, seems to work perfectly as well. Gotta say the tool has improved a lot recently and is pretty awesome now!

One question - I noticed that it is adjusting the barometer setting during flight. I assume (haven't tested this yet) that this is disabled during paused mode, right? Also (I haven't paid attention to this before) - doesn't this mean that when you fly above transition altitude with standard baro setting (29.92) that the tool would set it to something else during acceleration?

daheise commented 3 years ago

Yes, it will set the barometer at every sim rate change, so if you pause it won’t happen because there’s no further changes.

As far as I can tell, MSFS correctly sets the barometer to standard at FL180.

I plan to add an option to disable that.

ghost commented 3 years ago

Yeah I think a setting would be good, as e.g. in Europe the transition altitudes are completely different (even by location), and I don't believe MSFS is handling that...

daheise commented 3 years ago

That’s correct. At the moment 18,000ft/FL180 is what MSFS uses everywhere.

daheise commented 3 years ago

New release is up. Closing this issue.