dahlb / ha_carrier

Carrier Infinity Integration for Home Assistant
MIT License
50 stars 4 forks source link

Changing temp/mode in HA change Carrier to Hold Indefinitely, even when unchecked. #155

Closed VideoGoose closed 2 weeks ago

VideoGoose commented 4 weeks ago

System Health details

System Information

version core-2024.10.4
installation_type Home Assistant OS
dev false
hassio true
docker true
user root
virtualenv false
python_version 3.12.4
os_name Linux
os_version 6.6.31-haos-raspi
arch aarch64
timezone America/New_York
config_dir /config
Home Assistant Community Store GitHub API | ok -- | -- GitHub Content | ok GitHub Web | ok HACS Data | ok GitHub API Calls Remaining | 4983 Installed Version | 2.0.1 Stage | running Available Repositories | 1459 Downloaded Repositories | 26
Home Assistant Cloud logged_in | true -- | -- subscription_expiration | January 28, 2025 at 7:00 PM relayer_connected | true relayer_region | us-east-1 remote_enabled | true remote_connected | true alexa_enabled | false google_enabled | true remote_server | us-east-1-1.ui.nabu.casa certificate_status | ready instance_id | can_reach_cert_server | ok can_reach_cloud_auth | ok can_reach_cloud | ok
Home Assistant Supervisor host_os | Home Assistant OS 13.2 -- | -- update_channel | stable supervisor_version | supervisor-2024.10.3 agent_version | 1.6.0 docker_version | 27.2.0 disk_total | 28.0 GB disk_used | 20.7 GB healthy | true supported | true host_connectivity | true supervisor_connectivity | true ntp_synchronized | true virtualization | board | yellow supervisor_api | ok version_api | ok installed_addons | Terminal & SSH (9.15.0), Studio Code Server (5.17.2), Z-Wave JS (0.8.1), ESPHome (2024.10.2), Mosquitto broker (6.4.1), Piper (1.5.2), Whisper (2.2.0), openWakeWord (1.10.0), Matter Server (6.6.0)
keymaster zwave_integration | zwave_js -- | -- network_status | on
Dashboards dashboards | 6 -- | -- resources | 13 views | 16 mode | storage
Recorder oldest_recorder_run | October 28, 2024 at 11:41 PM -- | -- current_recorder_run | October 31, 2024 at 1:29 PM estimated_db_size | 259.43 MiB database_engine | sqlite database_version | 3.45.3

Checklist

Describe the issue

Whenever I adjust the thermostat in HA, carrier sets the thermostat to manual hold indefinitely instead of "hold until next scheduled profile." I have "Holds are infinite, when off holds are until next scheduled activity" currently unchecked. -- Apologies on the lack of some diagnostic data. I was having difficulty with the logging. I can gather more specific info as needed. Thank you for this project.

Reproduction steps

  1. Set carrier to run on schedule from app or HA
  2. Change temperature in HA.
  3. See in app it's set to hold indefinitely. ...

Debug logs

N/A

Diagnostics dump

NA Too Long

sdahbour commented 2 weeks ago

I’ve seen this issue consistently since I installed this component a couple months ago. I haven’t taken any steps to document or debug, but I can confirm this is an issue.

jrmrjnck commented 2 weeks ago

It looks like that setting only applies to when you change the preset mode: https://github.com/dahlb/ha_carrier/blob/1e2f46e2a204841bb4f3b7a28f4887c1c44449ac/custom_components/ha_carrier/climate.py#L278-L283

and not when you change the temperature: https://github.com/dahlb/ha_carrier/blob/1e2f46e2a204841bb4f3b7a28f4887c1c44449ac/custom_components/ha_carrier/climate.py#L335-L341

It would need an update to the carrier_api pypi library as well as this component, but I would also like to see this behavior implemented.

dahlb commented 2 weeks ago

1.23.0 was just released and it should respect the hold preference for manual activities too :) thanks for writing this up

jrmrjnck commented 2 weeks ago

Thanks @dahlb! I tested it and it seems to work as expected.

sdahbour commented 2 weeks ago

Working for me too.  Thank you for making that change!On Nov 14, 2024, at 2:26 PM, Jonathan Doman @.***> wrote: Thanks @dahlb! I tested it and it seems to work as expected.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>